WebGL2: fix import path for unpack_unorm3x4_plus_unorm_20_#10251
Merged
superdump merged 1 commit intobevyengine:mainfrom Oct 25, 2023
Merged
WebGL2: fix import path for unpack_unorm3x4_plus_unorm_20_#10251superdump merged 1 commit intobevyengine:mainfrom
superdump merged 1 commit intobevyengine:mainfrom
Conversation
robtfm
approved these changes
Oct 24, 2023
Contributor
robtfm
left a comment
robtfm
left a comment
There was a problem hiding this comment.
this fully fixes the issue for me on ff/win/rtx3070
DGriffin91
approved these changes
Oct 24, 2023
superdump
approved these changes
Oct 25, 2023
ameknite
pushed a commit
to ameknite/bevy
that referenced
this pull request
Nov 6, 2023
…e#10251) # Objective - Fixes bevyengine#10250 ``` [Log] ERROR crates/bevy_render/src/render_resource/pipeline_cache.rs:823 failed to process shader: (wasm_example.js, line 376) error: no definition in scope for identifier: 'bevy_pbr::pbr_deferred_functions::unpack_unorm3x4_plus_unorm_20_' ┌─ crates/bevy_pbr/src/deferred/deferred_lighting.wgsl:44:20 │ 44 │ frag_coord.z = bevy_pbr::pbr_deferred_functions::unpack_unorm3x4_plus_unorm_20_(deferred_data.b).w; │ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ unknown identifier │ = no definition in scope for identifier: 'bevy_pbr::pbr_deferred_functions::unpack_unorm3x4_plus_unorm_20_' ``` ## Solution - Fix the import path The "gray" issue is since bevyengine#9258 on macOS ... at least they're not white anymore <img width="1294" alt="Screenshot 2023-10-25 at 00 14 11" src="https://github.com/bevyengine/bevy/assets/8672791/df1a1138-c26c-4417-9b49-a00fbb8561d7">
rdrpenguin04
pushed a commit
to rdrpenguin04/bevy
that referenced
this pull request
Jan 9, 2024
…e#10251) # Objective - Fixes bevyengine#10250 ``` [Log] ERROR crates/bevy_render/src/render_resource/pipeline_cache.rs:823 failed to process shader: (wasm_example.js, line 376) error: no definition in scope for identifier: 'bevy_pbr::pbr_deferred_functions::unpack_unorm3x4_plus_unorm_20_' ┌─ crates/bevy_pbr/src/deferred/deferred_lighting.wgsl:44:20 │ 44 │ frag_coord.z = bevy_pbr::pbr_deferred_functions::unpack_unorm3x4_plus_unorm_20_(deferred_data.b).w; │ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ unknown identifier │ = no definition in scope for identifier: 'bevy_pbr::pbr_deferred_functions::unpack_unorm3x4_plus_unorm_20_' ``` ## Solution - Fix the import path The "gray" issue is since bevyengine#9258 on macOS ... at least they're not white anymore <img width="1294" alt="Screenshot 2023-10-25 at 00 14 11" src="https://github.com/bevyengine/bevy/assets/8672791/df1a1138-c26c-4417-9b49-a00fbb8561d7">
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Solution
The "gray" issue is since #9258 on macOS
... at least they're not white anymore
