Prevent double panic in the Drop of TaksPoolInner#1064
Merged
cart merged 1 commit intobevyengine:masterfrom Dec 22, 2020
Merged
Prevent double panic in the Drop of TaksPoolInner#1064cart merged 1 commit intobevyengine:masterfrom
cart merged 1 commit intobevyengine:masterfrom
Conversation
ac7b617 to
8ed9244
Compare
Member
|
This makes sense to me. Good call! |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TaskPoolInner would cause failing bevy test (see #1057) to abort the running test suite immediately.
Here is the problematic situation as I understand it:
joincall.exceptpanic when receiving an error.My idea is to only panic when the current thread is not already panicking.