Remove unnecessary path prefixes

[tygyh]

Objective

• Shorten paths by removing unnecessary prefixes

Solution

• Remove the prefixes from many paths which do not need them. Finding the paths was done automatically using built-in refactoring tools in Jetbrains RustRover.

[Nilirad]

Looks interesting but in some cases it seems quite aggressive. For example, Result prefix is sometimes helpful to know as there are many Result types. Also I have mixed feelings about stripping out the enum type when specifying a variant.

[tygyh]

I have changed 119 files, if nothing was controversial I would be concerned. :D

I already knew I would have to revert some parts. Just tell me what. And if it's too much work to go through it all I can break up the Pull Request into several smaller.

[alice-i-cecile]

Good changes. I'd like to get this through ASAP to avoid killing you with merge conflicts.

Some additional cleanup you can do, and I would really like a clippy lint for this.

I actually quite like not using path imports for std::Result. IMO that should be saved to call out unusual Result types that are punning. (Don't do this! Bad API!)

[tygyh]

Some additional cleanup you can do, and I would really like a clippy lint for this.

Do you want me to add a clippy lint? I have no idea how to do that.

[alice-i-cecile]

Lints are added at the workspace level here.

Now, let's check the list of clippy lints to see if anything matches...

The absolute_paths lint is closest but not quite the same. Let me open an issue!

[smoelius]

@alice-i-cecile I just wanted to point you to Dylint's inconsistent_qualification lint. It's very similar to the lint you proposed in rust-lang/rust-clippy#11888.

Please forgive me jumping on your PR.

[alice-i-cecile]

Very useful, no worries! I'm a bit nervous about adding another tool to our CI for now, but I'll keep it on my radar :)

[alice-i-cecile]

@tygyh once you can get this passing CI and free of merge conflicts, I'll merge this as trivial <3

[tygyh]

@alice-i-cecile It is ready now!