Skip to content

Remove System::{get,set}_last_run#10795

Closed
stepancheg wants to merge 1 commit intobevyengine:mainfrom
stepancheg:last-run
Closed

Remove System::{get,set}_last_run#10795
stepancheg wants to merge 1 commit intobevyengine:mainfrom
stepancheg:last-run

Conversation

@stepancheg
Copy link
Contributor

Dead code.

@nicopap nicopap added A-ECS Entities, components, systems, and events M-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide labels Nov 29, 2023
@github-actions
Copy link
Contributor

It looks like your PR is a breaking change, but you didn't provide a migration guide.

Could you add some context on what users should update when this change get released in a new version of Bevy?
It will be used to help writing the migration guide for the version. Putting it after a ## Migration Guide will help it get automatically picked up by our tooling.

@mockersf
Copy link
Member

this is in the public API so it can't be dead code, at most it's unused internally

@alice-i-cecile alice-i-cecile added the C-Code-Quality A section of code that is hard to understand or change label Nov 29, 2023
@alice-i-cecile
Copy link
Member

We shouldn't do this: this was specifically added in #5838 for public use.

This was renamed in #7905, so digging up the history was a bit tricky.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change M-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants