Skip to content

Allow the editing of startup schedules#10969

Merged
alice-i-cecile merged 2 commits intobevyengine:mainfrom
ItsDoot:feat/startup-schedule-order
Dec 14, 2023
Merged

Allow the editing of startup schedules#10969
alice-i-cecile merged 2 commits intobevyengine:mainfrom
ItsDoot:feat/startup-schedule-order

Conversation

@ItsDoot
Copy link
Contributor

@ItsDoot ItsDoot commented Dec 13, 2023

Objective

Fixes #10968

Solution

Pull startup schedules from a list of ScheduleLabels in the same way the update schedules are handled.


Changelog

  • Added MainScheduleOrder::startup_labels to allow the editing of the startup schedule order.

Migration Guide

  • Added a new field to MainScheduleOrder, startup_labels, for editing the startup schedule order.

@ItsDoot ItsDoot added A-ECS Entities, components, systems, and events C-Usability A targeted quality-of-life change that makes Bevy easier to use labels Dec 13, 2023
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good! That's about as easy as I hoped it would be.

@alice-i-cecile alice-i-cecile added this to the 0.13 milestone Dec 13, 2023
@alice-i-cecile alice-i-cecile added the M-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide label Dec 13, 2023
@github-actions
Copy link
Contributor

It looks like your PR is a breaking change, but you didn't provide a migration guide.

Could you add some context on what users should update when this change get released in a new version of Bevy?
It will be used to help writing the migration guide for the version. Putting it after a ## Migration Guide will help it get automatically picked up by our tooling.

@alice-i-cecile
Copy link
Member

alice-i-cecile commented Dec 13, 2023

Oh, this is technically breaking since we've added a new field to a public struct. For all of the 0 people explicitly constructing this!

@ItsDoot
Copy link
Contributor Author

ItsDoot commented Dec 13, 2023

Oh, this is technically breaking since we've added a new field to a public struct. For all of the 0 people explicitly constructing this!

Added a simple migration guide 👍

@andriyDev
Copy link
Contributor

This might be another issue, but should we also add support for PreFixedUpdate/PostFixedUpdate? This same mechanism could be used for that too.

Someone in the discord was asking about PostFixedUpdate 😅

@alice-i-cecile
Copy link
Member

That's clever. Happy to see it done, here or elsewhere, but we shouldn't block this PR on that.

@ItsDoot
Copy link
Contributor Author

ItsDoot commented Dec 13, 2023

This might be another issue, but should we also add support for PreFixedUpdate/PostFixedUpdate? This same mechanism could be used for that too.

Happy to look into it in a separate PR. 👍

@alice-i-cecile alice-i-cecile added this pull request to the merge queue Dec 14, 2023
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Dec 14, 2023
Merged via the queue into bevyengine:main with commit a4e0a0c Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ECS Entities, components, systems, and events C-Usability A targeted quality-of-life change that makes Bevy easier to use M-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow the list of startup schedules to be configured, similar to the update schedules

4 participants