Add testing to Commands run_system functions#11124
Closed
pablo-lua wants to merge 3 commits intobevyengine:mainfrom
Closed
Add testing to Commands run_system functions#11124pablo-lua wants to merge 3 commits intobevyengine:mainfrom
pablo-lua wants to merge 3 commits intobevyengine:mainfrom
Conversation
alice-i-cecile
approved these changes
Dec 28, 2023
alice-i-cecile
added
A-ECS
Member
|
@doonv can I get your review here? |
Contributor
Author
|
Just to be sure, the CI problem is related to that one problem mentioned in #11123? Never touched the file in question after all |
Member
|
Yep, not your problem. |
Contributor
|
btw i dont think there should be changelogs for this because there's no external changes. it's all internal tests |
alice-i-cecile
added
the
S-Ready-For-Final-Review
Contributor
Author
|
Giving it a second look: in system_registry.rs there is already two existent tests to this subject: nested_systems and nested_systems_with_inputs, so this PR doesn't really have a reason to exist, and therefore, I'm closing it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Commands::run_systemandCommands::run_system_with_input, this is a follow up of the possibilitySolution
Commandstests