Remove apply_deferred example#11142
Merged
alice-i-cecile merged 1 commit intobevyengine:mainfrom Jan 8, 2024
Merged
Conversation
80ab1da to
c1b9da1
Compare
joseph-gio
approved these changes
Jan 4, 2024
Member
joseph-gio
left a comment
There was a problem hiding this comment.
I agree, let's get rid of this. This will be stored in git so we can always bring it back and adapt it if we want to make an example aimed at power users.
hymm
approved these changes
Jan 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Re this comment: #11141 (comment)
Since #9822, Bevy automatically inserts
apply_deferredbetween systems with dependencies where needed, so manually insertedapply_deferreddoesn't to anything useful, and in current state this example does more harm than good.Solution
The example can be modified with removal of automatic
apply_deferredinsertion, but that would immediately upgrade this example from beginner level, to upper intermediate. Most users don't need to disable automatic sync point insertion, and remaining few who do probably already know how it works.CC @hymm