fix B0003 example and update logs#11162
Merged
mockersf merged 7 commits intobevyengine:mainfrom Jan 10, 2024
Merged
Conversation
alice-i-cecile
approved these changes
Jan 1, 2024
Member
alice-i-cecile
left a comment
alice-i-cecile
left a comment
There was a problem hiding this comment.
Grammar nit, but LGTM.
Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>
Member
|
@doonv @killercup could I get a review from one or both of you? |
doonv
reviewed
Jan 1, 2024
doonv
approved these changes
Jan 10, 2024
alice-i-cecile
added
the
S-Ready-For-Final-Review
Member
|
@mockersf go ahead and merge this once CI is green. |
This reverts commit cea4809.
doonv
approved these changes
Jan 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Solution