Fair Change Detection Benchmarking#11173
Merged
alice-i-cecile merged 11 commits intobevyengine:mainfrom Jun 26, 2024
Merged
Conversation
rlidwka
reviewed
Jan 2, 2024
james7132
reviewed
Jan 2, 2024
Member
james7132
left a comment
There was a problem hiding this comment.
This looks well motivated and the reasoning works out, but I'd like to see how much of an impact this has on the final benchmark numbers. This isn't to say the PR will be blocked on them changing in a particular direction, but it's best we show what impact this has.
Contributor
Author
ThierryBerger
approved these changes
Jun 26, 2024
alice-i-cecile
approved these changes
Jun 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Objective
iter_batchcause a lot of overhead in clone data to each routine closure(it feels like a bug initer_batch) and constructs new query in every iter.This overhead masks the real change detection throughput we want to measure. Instead of evaluating raw change detection, the benchmark ends up dominated by data cloning and allocation costs.Solution
Changelog