UI and unloaded assets: don't filter out nodes with an unloaded image#11205
Merged
alice-i-cecile merged 3 commits intobevyengine:mainfrom Jan 24, 2024
Merged
UI and unloaded assets: don't filter out nodes with an unloaded image#11205alice-i-cecile merged 3 commits intobevyengine:mainfrom
alice-i-cecile merged 3 commits intobevyengine:mainfrom
Conversation
mockersf
added
C-Bug
JMS55
approved these changes
Jan 4, 2024
alice-i-cecile
approved these changes
Jan 24, 2024
Member
|
@mockersf is this still needed? The associated PR was disabled by default. |
Contributor
|
I think this is still needed. It was disabled by default, but that doesn't mean users won't use it. |
alice-i-cecile
added
the
S-Ready-For-Final-Review
Member
|
Sounds good. Feel free to merge (or bug me) once merge conflicts are fixed. |
tjamaan
pushed a commit
to tjamaan/bevy
that referenced
this pull request
Feb 6, 2024
…bevyengine#11205) # Objective - after bevyengine#10520, UI can't display images or text with a background color ## Solution - don't filter out UI nodes with an unloaded image
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Solution