assets should be kept on CPU by default#11212
Merged
alice-i-cecile merged 1 commit intobevyengine:mainfrom Jan 5, 2024
Merged
Conversation
mockersf
added
the
A-Assets
Member
|
I think this is a less surprising behavior. The performance gains are huge from doing this, but it's extremely surprising to beginners and very breaking. |
alice-i-cecile
approved these changes
Jan 4, 2024
JMS55
approved these changes
Jan 5, 2024
Contributor
JMS55
left a comment
JMS55
left a comment
There was a problem hiding this comment.
I hate to do this, but fair enough :(
JMS55
added
the
S-Ready-For-Final-Review
maximetinu
pushed a commit
to Sophya/bevy
that referenced
this pull request
Feb 12, 2024
# Objective - Since bevyengine#10520, assets are unloaded from RAM by default. This breaks a number of scenario: - using `load_folder` - loading a gltf, then going through its mesh to transform them / compute a collider / ... - any assets/subassets scenario should be `Keep` as you can't know what the user will do with the assets - android suspension, where GPU memory is unloaded - Alternative to bevyengine#11202 ## Solution - Keep assets on CPU memory by default
maximetinu
pushed a commit
to Sophya/bevy
that referenced
this pull request
Feb 12, 2024
# Objective - Since bevyengine#10520, assets are unloaded from RAM by default. This breaks a number of scenario: - using `load_folder` - loading a gltf, then going through its mesh to transform them / compute a collider / ... - any assets/subassets scenario should be `Keep` as you can't know what the user will do with the assets - android suspension, where GPU memory is unloaded - Alternative to bevyengine#11202 ## Solution - Keep assets on CPU memory by default
maximetinu
pushed a commit
to Sophya/bevy
that referenced
this pull request
Feb 12, 2024
# Objective - Since bevyengine#10520, assets are unloaded from RAM by default. This breaks a number of scenario: - using `load_folder` - loading a gltf, then going through its mesh to transform them / compute a collider / ... - any assets/subassets scenario should be `Keep` as you can't know what the user will do with the assets - android suspension, where GPU memory is unloaded - Alternative to bevyengine#11202 ## Solution - Keep assets on CPU memory by default
maximetinu
pushed a commit
to Sophya/bevy
that referenced
this pull request
Feb 12, 2024
# Objective - Since bevyengine#10520, assets are unloaded from RAM by default. This breaks a number of scenario: - using `load_folder` - loading a gltf, then going through its mesh to transform them / compute a collider / ... - any assets/subassets scenario should be `Keep` as you can't know what the user will do with the assets - android suspension, where GPU memory is unloaded - Alternative to bevyengine#11202 ## Solution - Keep assets on CPU memory by default
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Since Unload render assets from RAM #10520, assets are unloaded from RAM by default. This breaks a number of scenario:
load_folderKeepas you can't know what the user will do with the assetsAlternative to texture atlas example: mark each loaded image as CPU persistent #11202
Solution