Make TypeId::hash more robust in case of upstream rustc changes#11334
Merged
alice-i-cecile merged 1 commit intobevyengine:mainfrom Jan 14, 2024
Merged
Conversation
alice-i-cecile
changed the title
TypeId::hash more robustTypeId::hash more robust in case of upstream rustc changes
alice-i-cecile
approved these changes
Jan 13, 2024
alice-i-cecile
added
C-Code-Quality
Member
|
@NthTensor @orzogc I'd appreciate a quick review from one or both of you here :) |
NthTensor
approved these changes
Jan 14, 2024
alice-i-cecile
added
the
S-Ready-For-Final-Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on discussion after #11268 was merged:
Instead of panicking should the impl of
TypeId::hashchange significantly, have a fallback and detect this in a test.