Extract examples CameraController into a module#11338
Merged
alice-i-cecile merged 2 commits intobevyengine:mainfrom Jan 14, 2024
Merged
Extract examples CameraController into a module#11338alice-i-cecile merged 2 commits intobevyengine:mainfrom
CameraController into a module#11338alice-i-cecile merged 2 commits intobevyengine:mainfrom
Conversation
atlv24
approved these changes
Jan 14, 2024
IceSentry
suggested changes
Jan 14, 2024
Contributor
IceSentry
left a comment
IceSentry
left a comment
There was a problem hiding this comment.
The shadow_biases example shows the controls with bevy_ui. Did you confirm they are the same controls? Alternatively it could be removed for anything that is related to camera controls.
Contributor
Author
|
They were the same controls, but not even all of them. I removed them from UI |
matiqo15
added
C-Examples
alice-i-cecile
approved these changes
Jan 14, 2024
Member
alice-i-cecile
left a comment
alice-i-cecile
left a comment
There was a problem hiding this comment.
Happy to extract this for now to reduce duplication and make the examples more legible. Down the line, this should live in bevy_debug_tools IMO (see #11309).
alice-i-cecile
added
the
S-Ready-For-Final-Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Unify flycam-style camera controller from the examples.
parallax_mappingcontroller was kept as is.Solution
Fixed some mouse movement & cursor grabbing related issues too.