Skip to content

Tweak gamepad viewer example style#11484

Merged
mockersf merged 3 commits intobevyengine:mainfrom
rparrett:gamepad-viewer
Jan 23, 2024
Merged

Tweak gamepad viewer example style#11484
mockersf merged 3 commits intobevyengine:mainfrom
rparrett:gamepad-viewer

Conversation

@rparrett
Copy link
Contributor

Objective

Since #10339, the contrast in this example has been very low. While I was in there, I made a few other tweaks to the style.

Alternative to #10102.

Solution

  • Increase brightness of inactive buttons for higher contrast on the new clear color
  • Combine DEAD_COLOR and EXTENT_COLOR. These were using the same value, and combining them might make the intent a little clearer. (This is the single color for "not the live zone.")
  • Make the "stick buttons" slightly smaller, so it's a bit more obvious that they are sitting inside of the default dead zone.
  • Remove explicit text color -- it was the same as the default
  • Add top-left margin to the text in the top left, and change the font size to better match other examples with text in the corner.

Screenshots

With Bevy's default dead / live zones. Before / After

default

With Bevy's old dead / live zones. (with the upper live zone boundary != 1.0) Before / After

old

@rparrett rparrett added C-Examples An addition or correction to our examples C-Code-Quality A section of code that is hard to understand or change labels Jan 23, 2024
@mockersf mockersf added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Jan 23, 2024
@mockersf mockersf added this pull request to the merge queue Jan 23, 2024
Merged via the queue into bevyengine:main with commit 2951ddf Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-Code-Quality A section of code that is hard to understand or change C-Examples An addition or correction to our examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants