Tweak gamepad viewer example style#11484
Merged
mockersf merged 3 commits intobevyengine:mainfrom Jan 23, 2024
Merged
Conversation
IceSentry
approved these changes
Jan 23, 2024
mockersf
approved these changes
Jan 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Since #10339, the contrast in this example has been very low. While I was in there, I made a few other tweaks to the style.
Alternative to #10102.
Solution
DEAD_COLORandEXTENT_COLOR. These were using the same value, and combining them might make the intent a little clearer. (This is the single color for "not the live zone.")Screenshots
With Bevy's default dead / live zones.
Before / AfterWith Bevy's old dead / live zones. (with the upper live zone boundary != 1.0)
Before / After