Refactor tonemapping example's image viewer update into two systems#11519
Merged
alice-i-cecile merged 4 commits intobevyengine:mainfrom Jan 27, 2024
Merged
Refactor tonemapping example's image viewer update into two systems#11519alice-i-cecile merged 4 commits intobevyengine:mainfrom
alice-i-cecile merged 4 commits intobevyengine:mainfrom
Conversation
alice-i-cecile
added
C-Bug
rparrett
changed the title
atlv24
approved these changes
Jan 27, 2024
alice-i-cecile
approved these changes
Jan 27, 2024
alice-i-cecile
added
the
S-Ready-For-Final-Review
tjamaan
pushed a commit
to tjamaan/bevy
that referenced
this pull request
Feb 6, 2024
…evyengine#11519) # Objective Alternative to bevyengine#11515. Fixes change detection being triggered on the "image viewer image material" every frame. ## Solution - Split the megasystem into two separate systems: one to handle drop events, and one to handle asset change events. - Move the event reader iteration "outside." so that we're only doing stuff when there are events. - Flatten some of the more extreme nesting - Other bits of cleanup, removing an unnecessary clone and unused variable. I think these systems can even run in parallel now, not that it particularly matters.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Alternative to #11515.
Fixes change detection being triggered on the "image viewer image material" every frame.
Solution
I think these systems can even run in parallel now, not that it particularly matters.