Add Animated Material example#11524
Merged
alice-i-cecile merged 7 commits intobevyengine:mainfrom Jan 26, 2024
Merged
Conversation
alice-i-cecile
approved these changes
Jan 25, 2024
Member
alice-i-cecile
left a comment
alice-i-cecile
left a comment
There was a problem hiding this comment.
Awesome! This is a handy learning example, and being able to reproduce the performance problems is a nice bonus.
alice-i-cecile
added
A-Rendering
IceSentry
approved these changes
Jan 26, 2024
Contributor
IceSentry
left a comment
IceSentry
left a comment
There was a problem hiding this comment.
There's not enough instances to reproduce the performance issues on my machine. I need a 10x10 grid to start to see a real effect, but this is a good example either way so I'm fine with it as is.
alice-i-cecile
added
the
S-Ready-For-Final-Review
tjamaan
pushed a commit
to tjamaan/bevy
that referenced
this pull request
Feb 6, 2024
# Objective - Fixes bevyengine#11516 ## Solution - Add Animated Material example (colors are hue-cycling smoothly per-mesh)  Note: this example reproduces the perf issue found in bevyengine#10610 pretty consistently, with and without the changes from that PR included. Frame time is sometimes around 4.3ms, other times around 12-14ms. Its pretty random per run. I think this clears bevyengine#10610 for merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Solution
Note: this example reproduces the perf issue found in #10610 pretty consistently, with and without the changes from that PR included. Frame time is sometimes around 4.3ms, other times around 12-14ms. Its pretty random per run. I think this clears #10610 for merge.