Add Border and CornerRadius components to bevy_ui (Adopted)#11813
Closed
tygyh wants to merge 1 commit intobevyengine:mainfrom
Closed
Add Border and CornerRadius components to bevy_ui (Adopted)#11813tygyh wants to merge 1 commit intobevyengine:mainfrom
tygyh wants to merge 1 commit intobevyengine:mainfrom
Conversation
alice-i-cecile
added
C-Feature
tygyh
force-pushed
the
ui-nodes-new-visual-features
branch
from
f93938d to
1f5130f
Compare
tygyh
force-pushed
the
ui-nodes-new-visual-features
branch
from
1f5130f to
2c93385
Compare
Contributor
|
What's the difference between this pr and this one #8973? |
Contributor
Author
The other one's changes are probably a superset of this one and other changes. |
tygyh
force-pushed
the
ui-nodes-new-visual-features
branch
from
2c93385 to
9045db9
Compare
tygyh
force-pushed
the
ui-nodes-new-visual-features
branch
from
9045db9 to
a68b9ee
Compare
Contributor
Author
|
Since this PR is ready for review and #8973 is dormant I'd like to make partial progress by merging this |
tygyh
force-pushed
the
ui-nodes-new-visual-features
branch
from
a68b9ee to
2e7d084
Compare
Member
|
This PR doesn't seem to actually contain any code to render anything. I don't think this is in a mergeable state until a) it has rendering attached and b) the feature is demonstrated in an example. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Solution