bevy_reflect incorrectly looks for bevy in dev-deps#1182
bevy_reflect incorrectly looks for bevy in dev-deps#1182cart merged 2 commits intobevyengine:masterfrom
Conversation
fixed format
92bf463 to
e5ffef7
Compare
|
After giving it some thought I realized this means bevy_reflect will no longer work in situations in which examples need bevy_reflect only as a dev dependency. I need to change this. |
|
Hmm isn't this effectively a no-op change? How is accepting both dev and normal deps different from first accepting normal, then falling back to dev? |
|
Consider the following: [dependencies]
bevy_reflect = "*"
[dev-dependencies]
bevy = "*"Originally, the first case would incorrectly use Now consider the following: [dependencies]
# nothing
[dev-dependencies]
bevy = "*"Without the dev-deps fallback, bevy would not be located if the examples use bevy::reflect. |
|
Ah right. I wasn't considering the case where you have the full bevy crate and a subcrate. |
When trying to determine how it should mention itself in derive macros, the crate finder incorrectly assumes it can use
bevy::reflectif bevy is available as a dev dependency. This PR fixes this behavior by ignoring dev-dependencies.