only update Touches resource when needed

[JeanMertz]

Objective

• The touch_screen_input_system system runs on every tick.
• It unconditionally calls update(&mut self), on the Touches resource.
• This blocks the usage of a resource_changed::<Touches> run condition.

Solution

• Remove update(&mut self) as it's only used in this one system, and in-lining the method implementation removes an indirection to an ambiguously named method.
• Add conditional checks around the calls to clearing the internal maps.

[thebluefish]

We don't really need to tie these 3 maps together like this, and I feel that attempting to split this into separate methods to check and clear just muddy it up. I would prefer something more along the lines of

pub fn touch_screen_input_system(
    mut touch_state: ResMut<Touches>,
    mut touch_input_events: EventReader<TouchInput>,
) {
    if !touch_state.just_pressed.is_empty() {
        touch_state.just_pressed.clear();
    }
    if !touch_state.just_released.is_empty() {
        touch_state.just_released.clear();
    }
    if !touch_state.just_canceled.is_empty() {
        touch_state.just_canceled.clear();
    }

    for event in touch_input_events.read() {
        touch_state.process_touch_event(event);
    }
}```

[JeanMertz]

We don't really need to tie these 3 maps together like this

Yeah, I was wondering why this was done as well. Happy to make that change 👍

[JeanMertz]

@thebluefish made the changes as mentioned, LMKWYT.

[thebluefish]

Looks good

[alice-i-cecile]

If this is just used in tests, it should be called something like clear_all.

[JeanMertz]

Changed in 1b3d0bd (with the caveat that clear_all is a misnomer, as it only clears three of the four maps in Touches)

[alice-i-cecile]

Looks good :)

[BD103]

The CI error on Windows does not seem related to the changes in this PR. The Windows crate was updated within the past two hours, so I think it may be the source of the issue.

Edit:

Yup, it was the Windows crate. See microsoft/windows-rs#2870 and microsoft/windows-rs#2869.

[kennykerr]

An update is on the way.

[kennykerr]

The windows-targets crate has now been updated.

[alice-i-cecile]

Awesome, thank you @kennykerr. Retrying CI and attempting to merge :)