Slicing support for texture atlas#12059
Merged
alice-i-cecile merged 13 commits intobevyengine:mainfrom Mar 5, 2024
Merged
Conversation
Contributor
|
You added a new example but didn't add metadata for it. Please update the root Cargo.toml file. |
2 similar comments
Contributor
|
You added a new example but didn't add metadata for it. Please update the root Cargo.toml file. |
Contributor
|
You added a new example but didn't add metadata for it. Please update the root Cargo.toml file. |
Contributor
|
The generated |
alice-i-cecile
added
C-Feature
ManevilleF
force-pushed
the
feat/texture_atlas_slicing
branch
from
56dca72 to
510ed67
Compare
pablo-lua
approved these changes
Mar 2, 2024
Contributor
pablo-lua
left a comment
pablo-lua
left a comment
There was a problem hiding this comment.
I don't really like the fact that there is a duplicate code between ui slice and sprite slice, but that can be a follow up in the future.
Just a couple mispelling here, LGTM
james7132
added
the
S-Ready-For-Final-Review
Member
|
@ManevilleF can you format this when you get a chance? |
auto-merge was automatically disabled
March 5, 2024 09:01
Head branch was pushed to by a user without write access
Contributor
Author
|
@alice-i-cecile Done ! |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 5, 2024
# Objective The docs say that atlas and slicing are incompatible, but they are now compatible after #12059. ## Solution Update the docs.
spectria-limina
pushed a commit
to spectria-limina/bevy
that referenced
this pull request
Mar 9, 2024
# Objective Follow up to bevyengine#11600 and bevyengine#10588 bevyengine#11944 made clear that some people want to use slicing with texture atlases ## Changelog * Added support for `TextureAtlas` slicing and tiling. `SpriteSheetBundle` and `AtlasImageBundle` can now use `ImageScaleMode` * Added new `ui_texture_atlas_slice` example using a texture sheet <img width="798" alt="Screenshot 2024-02-23 at 11 58 35" src="https://github.com/bevyengine/bevy/assets/26703856/47a8b764-127c-4a06-893f-181703777501"> --------- Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com> Co-authored-by: Pablo Reinhardt <126117294+pablo-lua@users.noreply.github.com>
spectria-limina
pushed a commit
to spectria-limina/bevy
that referenced
this pull request
Mar 9, 2024
# Objective The docs say that atlas and slicing are incompatible, but they are now compatible after bevyengine#12059. ## Solution Update the docs.
msvbg
pushed a commit
to msvbg/bevy
that referenced
this pull request
Jun 11, 2024
Follow up to bevyengine#11600 and bevyengine#10588 bevyengine#11944 made clear that some people want to use slicing with texture atlases * Added support for `TextureAtlas` slicing and tiling. `SpriteSheetBundle` and `AtlasImageBundle` can now use `ImageScaleMode` * Added new `ui_texture_atlas_slice` example using a texture sheet <img width="798" alt="Screenshot 2024-02-23 at 11 58 35" src="https://github.com/bevyengine/bevy/assets/26703856/47a8b764-127c-4a06-893f-181703777501"> --------- Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com> Co-authored-by: Pablo Reinhardt <126117294+pablo-lua@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Follow up to #11600 and #10588
#11944 made clear that some people want to use slicing with texture atlases
Changelog
TextureAtlasslicing and tiling.SpriteSheetBundleandAtlasImageBundlecan now useImageScaleModeui_texture_atlas_sliceexample using a texture sheet