fix example lightmaps after color migration#12265
Merged
alice-i-cecile merged 2 commits intobevyengine:mainfrom Mar 3, 2024
Merged
fix example lightmaps after color migration#12265alice-i-cecile merged 2 commits intobevyengine:mainfrom
alice-i-cecile merged 2 commits intobevyengine:mainfrom
Conversation
mockersf
added
A-Rendering
alice-i-cecile
requested changes
Mar 2, 2024
Member
alice-i-cecile
left a comment
alice-i-cecile
left a comment
There was a problem hiding this comment.
Hmm, this is an interesting case where the gamma correction of Srgba is useful. Good catch.
We should impl Div and the reciprocal Mul in this PR too however.
alice-i-cecile
approved these changes
Mar 3, 2024
pablo-lua
approved these changes
Mar 3, 2024
Contributor
pablo-lua
left a comment
pablo-lua
left a comment
There was a problem hiding this comment.
I like the Mul and Div implementation, and the example is better now.
alice-i-cecile
added
the
S-Ready-For-Final-Review
spectria-limina
pushed a commit
to spectria-limina/bevy
that referenced
this pull request
Mar 9, 2024
# Objective - Since bevyengine#12163 example lightmaps is more dull <img width="1280" alt="Screenshot 2024-03-02 at 23 04 36" src="https://github.com/bevyengine/bevy/assets/8672791/7736f420-b9c5-4870-93f6-b5b992c4768a"> ## Solution - Use a srgba color, as it was before: https://github.com/bevyengine/bevy/blob/b24ab2e9fba5b81aba15da97b6551a4e99aad40c/examples/3d/lightmaps.rs#L39 https://github.com/bevyengine/bevy/blob/b24ab2e9fba5b81aba15da97b6551a4e99aad40c/crates/bevy_render/src/color/mod.rs#L132 <img width="1280" alt="Screenshot 2024-03-02 at 23 05 09" src="https://github.com/bevyengine/bevy/assets/8672791/451187ed-8612-456f-ad25-180d5f774188">
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
LegacyColortobevy_color::Color#12163 example lightmaps is more dullSolution
bevy/examples/3d/lightmaps.rs
Line 39 in b24ab2e
bevy/crates/bevy_render/src/color/mod.rs
Line 132 in b24ab2e