Fix minimal plugins in ci#12370
Merged
alice-i-cecile merged 2 commits intobevyengine:mainfrom Mar 7, 2024
Merged
Conversation
mockersf
added
C-Bug
alice-i-cecile
approved these changes
Mar 7, 2024
Member
|
@matiqo15 can I get your review here? |
kristoff3r
approved these changes
Mar 7, 2024
alice-i-cecile
added
the
S-Ready-For-Final-Review
spectria-limina
pushed a commit
to spectria-limina/bevy
that referenced
this pull request
Mar 9, 2024
# Objective - bevyengine#11341 broke running code using `MinimalPlugins` in CI ## Solution - include `DevToolsPlugin` in `MinimalPlugins`
spectria-limina
pushed a commit
to spectria-limina/bevy
that referenced
this pull request
Mar 9, 2024
…le (bevyengine#12385) # Objective - After bevyengine#12370, ci testing with minimal plugins doesn't hang but it crash as the resource `ScreenshotManager` doesn't exist ## Solution - Check if the resource exists
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
MinimalPluginsin CISolution
DevToolsPlugininMinimalPlugins