Change 'components' to 'bundles' where it makes sense semantically#1257
Merged
cart merged 2 commits intobevyengine:masterfrom Jan 19, 2021
CleanCut:bundle
Merged
Change 'components' to 'bundles' where it makes sense semantically#1257cart merged 2 commits intobevyengine:masterfrom CleanCut:bundle
cart merged 2 commits intobevyengine:masterfrom
CleanCut:bundle
Conversation
CleanCut
commented
Jan 18, 2021
| //! | ||
| //! ### This Crate | ||
| //! The `bevy` crate is just a container crate that makes it easier to consume Bevy components. | ||
| //! The `bevy` crate is just a container crate that makes it easier to consume Bevy subcrates. |
Member
Author
There was a problem hiding this comment.
This one-off change is to avoid confusion between the abstract meaning of "components" and the ECS meaning by being more specific.
alice-i-cecile
approved these changes
Jan 18, 2021
Member
alice-i-cecile
left a comment
alice-i-cecile
left a comment
There was a problem hiding this comment.
These changes are simple and should have no actual effect on the compiled code while making these bits of the source nicer to understand :)
Member
|
Yup good calls all around! |
rparrett
pushed a commit
to rparrett/bevy
that referenced
this pull request
Jan 27, 2021
…evyengine#1257) change 'components' to 'bundles' where it makes sense semantically
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following #863 there is a "bundle" concept that semantically means a specific set of types of components we want to add at one time for some given purpose (my wording).
I searched through the codebase and found the places where "components" was still being used in that context, and changed them to "bundle". This couldn't be done via regex since there are many other places that "components" is used in a different context, so I did this through manual inspection. Hopefully my interpretation was accurate! 😄
Some changes similar to these were made in #976