Skip to content

CI Tuning#1318

Merged
cart merged 4 commits intobevyengine:masterfrom
CleanCut:ci-tuning
Jan 27, 2021
Merged

CI Tuning#1318
cart merged 4 commits intobevyengine:masterfrom
CleanCut:ci-tuning

Conversation

@CleanCut
Copy link
Member

@CleanCut CleanCut commented Jan 26, 2021

Prompted by #1309 (comment)

  • Simplified syntax & linted. Think "rustfmt" for github actions toml files.
  • Combined apt updates and installations into a single step (why update twice? why separate installations?)
  • Future-proofed OS selections by using *-latest, which never gets old, as opposed to specific version numbers.
  • Remove cache step after verifying cache isn't being used and is just wasting time.
  • 😄 Merge clean job into the linux stable job...which is what I actually started out to do.
  • ⚠️ Enable actually building and running tests on Windows and macOS. Apparently they haven't been running for quite some time, though cargo check was.

Before: 8 jobs with typical total runtime of 17m - 18m (CI jobs are very noisy, so total runtime varies quite a bit)
Now: 7 jobs with typical total runtime of 14m. We shaved a few minutes off, and 2 of the remaining builds are actually building and testing now when they weren't before.

@CleanCut CleanCut marked this pull request as ready for review January 26, 2021 05:34
@CleanCut CleanCut mentioned this pull request Jan 26, 2021
@cart cart merged commit 3529dd6 into bevyengine:master Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants