Wgpu 0.20 by Elabajaba · Pull Request #13186 · bevyengine/bevy

Elabajaba · 2024-05-02T20:17:59Z

Currently blocked on gfx-rs/wgpu#5774

Objective

Update to wgpu 0.20

Solution

Update to wgpu 0.20 and naga_oil 0.14.

Testing

Tested a few different examples on linux (vulkan, webgl2, webgpu) and windows (dx12 + vulkan) and they worked.

Changelog

Updated to wgpu 0.20, naga 0.20, and naga_oil 0.14. Note that we don't currently support wgpu's new pipeline overridable constants, as they don't work on web currently and need some more changes to naga_oil (and are somewhat redundant with naga_oil's shader defs). See wgpu's changelog for more https://github.com/gfx-rs/wgpu/blob/trunk/CHANGELOG.md#v0200-2024-04-28
You can now use many numeric built-ins in const contexts (eg. abs, cos, floor, max, etc, see https://github.com/gfx-rs/wgpu/blob/v0.20/CHANGELOG.md#wgsl-const-evaluation-for-many-more-built-ins for the whole list)
You can now use Subgroup operations in shaders on supported hardware (see https://github.com/gfx-rs/wgpu/blob/v0.20/CHANGELOG.md#subgroup-operations for limitations and which features to check)
u64 and i64 are now supported in shaders on supported hardware (requires the SHADER_INT64 feature, supported on desktop Vulkan, DX12 with DXC, and Metal with MSL 2.3+)

Migration Guide

Updated to wgpu 0.20, naga 0.20, and naga_oil 0.14
All of Naga's Capabilities should now be properly detected and supported.
Timestamps inside encoders are now disallowed on WebGPU to follow the spec (they still work on native). Use the TIMESTAMP_QUERY_INSIDE_ENCODERS wgpu feature to check for support.
You can now use many numeric built-ins in const contexts (eg. abs, cos, floor, max, etc, see https://github.com/gfx-rs/wgpu/blob/v0.20/CHANGELOG.md#wgsl-const-evaluation-for-many-more-built-ins for the whole list)
You can now use Subgroup operations in shaders on supported hardware (see https://github.com/gfx-rs/wgpu/blob/v0.20/CHANGELOG.md#subgroup-operations for limitations and which features to check)
u64 and i64 are now supported in shaders on supported hardware (requires the SHADER_INT64 feature, supported on desktop Vulkan, DX12 with DXC, and Metal with MSL 2.3+)

… no longer supported on WebGPU

Elabajaba · 2024-05-28T21:03:58Z

Technically we should wait for gfx-rs/wgpu#5681 to be backported before landing this, but that's supposed to be merged and released tomorrow (May 29th).

IceSentry

I tested a bunch of 2d and 3d examples on windows 10 with a 4080 and everything worked correctly.

Would be nice not having TODOs, but they can be addressed later. We should still ship 0.14 with this

LGTM

Elabajaba · 2024-05-28T23:23:10Z

I tested a bunch of 2d and 3d examples on windows 10 with a 4080 and everything worked correctly.

Would be nice not having TODOs, but they can be addressed later. We should still ship 0.14 with this

LGTM

The Todos shouldn't have any effect anyways, since they're for pipeline override constants which don't work on web currently (and aren't yet supported in naga_oil).

SIGSTACKFAULT · 2024-05-29T00:54:42Z

examples/3d_shapes dies of SIGBUS after ~5s on NixOS Unstable, RX6600.

2024-05-28.20-49-41.mp4

with --features wayland it brought Plasma down with it. The audio hitch is consistent.

EDIT: i relogged and now i can't reproduce it.

JMS55

Tested a bunch of 3d examples with VK + DX12, lgtm.

2024-05-29T06:50:45.203720Z  INFO bevy_diagnostic::system_information_diagnostics_plugin::internal: SystemInfo { os: "Windows 11 Home", kernel: "22631", cpu: "Intel(R) Core(TM) Ultra 7 155H", core_count: "16", memory: "15.6 GiB" }
2024-05-29T06:50:45.241110Z  INFO bevy_winit::system: Creating new window "App" (Entity { index: 0, generation: 1 })
2024-05-29T06:50:45.572420Z  INFO bevy_render::renderer: AdapterInfo { name: "Intel(R) Arc(TM) Graphics", vendor: 32902, device: 32085, device_type: IntegratedGpu, driver: "", driver_info: "", backend: Dx12 }

killercup · 2024-05-29T07:05:18Z

Tested a bunch of examples on an Apple M1 Pro and they all looked good.

Henauxg · 2024-05-29T07:59:30Z

Tested on Windows 11 with a 4070 + both Vulkan & Dx12.

Edit: Nevermind, checked the wrong branch... Examples are working fine for me.

IQuick143 · 2024-05-29T08:25:34Z

Did testing on Linux (NVIDIA, KDE, XOrg):

The two_passes example does not render anything:

Also causes major lag to the whole system (UI & Audio froze up for a few seconds) when opening and closing the window.

Equivalent behaviour in the split_screen example.

Similar hangs occur when a lot of resizing is done.

Other than that all 3d examples (except meshlets and clearcoat which I haven't tested) work.

Elabajaba · 2024-06-05T02:50:06Z

Is there an issue / PR we can link to that's blocking this? I saw that @Elabajaba ran into some Vulkan issues that pushed this to 0.15.

I tracked down what's causing the crash (using multiple command encoders) and made a wgpu issue for it gfx-rs/wgpu#5774.

cwfitzgerald · 2024-06-13T04:09:17Z

v0.20.1 is out now, thanks @Elabajaba for pushing this through!

JMS55 · 2024-06-13T05:04:43Z

We should check if this is fixed now:

bevy/crates/bevy_render/src/renderer/mod.rs

Line 372 in 2cffd14

    
           // HACK: Parallel command encoding is currently bugged on AMD + Windows + Vulkan with wgpu 0.19.1

mockersf · 2024-06-13T07:43:12Z

no issue in CI after the wgpu 0.20.1 update on the examples 🎉

BD103 · 2024-06-13T10:43:02Z

crates/bevy_color/Cargo.toml

 serde = { version = "1.0", features = ["derive"], optional = true }
 thiserror = "1.0"
-wgpu-types = { version = "0.19", default-features = false, optional = true }
+wgpu-types = { version = "0.20", default-features = false, optional = true }


Suggested change

wgpu-types = { version = "0.20", default-features = false, optional = true }

wgpu-types = { version = "0.20.1", default-features = false, optional = true }

If 0.20.0 was so problematic, we should prevent it from being pulled in by making 0.20.1 the minimum version.

BD103 · 2024-06-13T10:43:50Z

crates/bevy_render/Cargo.toml

 # When the 'atomics' feature is enabled `fragile-send-sync-non-atomic` does nothing
 # and Bevy instead wraps `wgpu` types to verify they are not used off their origin thread.
-wgpu = { version = "0.19.3", default-features = false, features = [
+wgpu = { version = "0.20", default-features = false, features = [


Suggested change

wgpu = { version = "0.20", default-features = false, features = [

wgpu = { version = "0.20.1", default-features = false, features = [

alice-i-cecile · 2024-06-13T11:18:05Z

I'm planning to merge this in right at the start of the 0.15 cycle.

xangelix · 2024-06-13T15:14:59Z

I'm planning to merge this in right at the start of the 0.15 cycle.

Is it possible we could get this in 0.14 and address any stability issues, if they happen, in further 0.14.x releases?
The upcoming release of egui will be on wgpu 0.20 and I'd like to keep the wgpu versions in sync if possible. emilk/egui#4560

alice-i-cecile · 2024-06-13T18:56:52Z

I'll check with the rendering SMEs and other maintainers :)

alice-i-cecile · 2024-06-13T19:31:28Z

Great; there's agreement to ship this in 0.14. Let me do a quick pass then let's get this merged.

alice-i-cecile · 2024-06-13T19:48:19Z

Diff looks reasonable, and it seems like the other issues are now resolved. Merging!

xangelix · 2024-06-13T20:55:06Z

Great; there's agreement to ship this in 0.14. Let me do a quick pass then let's get this merged.

Awesome, thanks so much!

Currently blocked on gfx-rs/wgpu#5774 # Objective Update to wgpu 0.20 ## Solution Update to wgpu 0.20 and naga_oil 0.14. ## Testing Tested a few different examples on linux (vulkan, webgl2, webgpu) and windows (dx12 + vulkan) and they worked. --- ## Changelog - Updated to wgpu 0.20. Note that we don't currently support wgpu's new pipeline overridable constants, as they don't work on web currently and need some more changes to naga_oil (and are somewhat redundant with naga_oil's shader defs). See wgpu's changelog for more https://github.com/gfx-rs/wgpu/blob/trunk/CHANGELOG.md#v0200-2024-04-28 ## Migration Guide TODO --------- Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com> Co-authored-by: François Mockers <mockersf@gmail.com>

Elabajaba added 2 commits May 2, 2024 16:10

wgpu trunk

5cc7bfc

wgpu 0.20 release version

b912c80

fmt

56dfe9c

mockersf mentioned this pull request May 2, 2024

Update wgpu requirement from 0.19.3 to 0.20.0 #13132

Closed

This was referenced May 3, 2024

Add handling for more naga capabilities #9000

Closed

Meshlet single pass depth downsampling (SPD) #13003

Merged

BD103 mentioned this pull request May 20, 2024

Update wgpu-types requirement from 0.19 to 0.20 #13434

Closed

mnmaita mentioned this pull request May 21, 2024

Bevy chooses CPU render device instead of integrated GPU #13113

Closed

JMS55 added this to the 0.14 milestone May 21, 2024

Elabajaba added 3 commits May 28, 2024 16:01

better naga capabilities detection and fixes for naga_oil changes

9b4d447

naga_oil 0.14

de96ea5

check for support for write_timestamp on CommandEncoders, as it's…

8fedb0c

… no longer supported on WebGPU

Elabajaba marked this pull request as ready for review May 28, 2024 21:01

alice-i-cecile added S-Needs-Review Needs reviewer attention (from anyone!) to move forward and removed S-Blocked This cannot move forward until something else changes labels May 28, 2024

IceSentry approved these changes May 28, 2024

View reviewed changes

Merge branch 'main' into wgpu-0.20

aecd7c1

alice-i-cecile added the S-Needs-Testing Testing must be done before this is safe to merge label May 29, 2024

JMS55 approved these changes May 29, 2024

View reviewed changes

alice-i-cecile mentioned this pull request Jun 8, 2024

Rendering Stutter/Ghosting on Vulkan Renderer #13742

Closed

Merge branch 'main' into wgpu-0.20

905ab8d

BD103 suggested changes Jun 13, 2024

View reviewed changes

alice-i-cecile modified the milestones: 0.15, 0.14 Jun 13, 2024

alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Blocked This cannot move forward until something else changes labels Jun 13, 2024

alice-i-cecile added this pull request to the merge queue Jun 13, 2024

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 13, 2024

alice-i-cecile mentioned this pull request Jun 14, 2024

STATUS_ACCESS_VIOLATION in CorePipelinePlugin #13559

Closed

mockersf approved these changes Jun 14, 2024

View reviewed changes

mockersf added this pull request to the merge queue Jun 14, 2024

Merged via the queue into bevyengine:main with commit 2825ac8 Jun 14, 2024

This was referenced Jun 16, 2024

Enable Wayland by default #10792

Closed

Bevy freezes on Wayland #10546

Open

Segfault on exit with multi_threaded feature disabled on Wayland after wgpu 0.20 #13958

Closed

alice-i-cecile mentioned this pull request Jul 17, 2024

Bevy 0.14 adds some very expensive debug assertions somewhere #14291

Open

re0312 mentioned this pull request Jul 24, 2024

Slow memory leak #14463

Closed

	wgpu-types = { version = "0.20", default-features = false, optional = true }
	wgpu-types = { version = "0.20.1", default-features = false, optional = true }

	wgpu = { version = "0.20", default-features = false, features = [
	wgpu = { version = "0.20.1", default-features = false, features = [

Uh oh!

Conversation

Elabajaba commented May 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Objective

Solution

Testing

Changelog

Migration Guide

Uh oh!

Elabajaba commented May 28, 2024

Uh oh!

IceSentry left a comment

Choose a reason for hiding this comment

Uh oh!

Elabajaba commented May 28, 2024

Uh oh!

SIGSTACKFAULT commented May 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JMS55 left a comment

Choose a reason for hiding this comment

Uh oh!

killercup commented May 29, 2024

Uh oh!

Henauxg commented May 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

IQuick143 commented May 29, 2024

Uh oh!

Elabajaba commented Jun 5, 2024

Uh oh!

cwfitzgerald commented Jun 13, 2024

Uh oh!

JMS55 commented Jun 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mockersf commented Jun 13, 2024

Uh oh!

BD103 Jun 13, 2024

Choose a reason for hiding this comment

Uh oh!

BD103 Jun 13, 2024

Choose a reason for hiding this comment

Uh oh!

alice-i-cecile commented Jun 13, 2024

Uh oh!

xangelix commented Jun 13, 2024

Uh oh!

alice-i-cecile commented Jun 13, 2024

Uh oh!

alice-i-cecile commented Jun 13, 2024

Uh oh!

alice-i-cecile commented Jun 13, 2024

Uh oh!

Uh oh!

xangelix commented Jun 13, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants

Elabajaba commented May 2, 2024 •

edited

Loading

SIGSTACKFAULT commented May 29, 2024 •

edited

Loading

Henauxg commented May 29, 2024 •

edited

Loading

JMS55 commented Jun 13, 2024 •

edited

Loading