Rename add_resource to insert_resource#1356
Merged
cart merged 3 commits intobevyengine:masterfrom Jan 30, 2021
alice-i-cecile:resource-rename
Merged
Rename add_resource to insert_resource#1356cart merged 3 commits intobevyengine:masterfrom alice-i-cecile:resource-rename
cart merged 3 commits intobevyengine:masterfrom
alice-i-cecile:resource-rename
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renames
AppBuilder::add_resourcetoAppBuilder::insert_resourcefor consistency with the Commands version. Also does the same foradd_thread_local_resource.A straightforward fix of #1352.