Add Skybox Motion Vectors#13617
Merged
alice-i-cecile merged 9 commits intobevyengine:mainfrom Jun 2, 2024
Merged
Conversation
alice-i-cecile
added
C-Feature
pcwalton
approved these changes
Jun 1, 2024
IceSentry
reviewed
Jun 2, 2024
IceSentry
approved these changes
Jun 2, 2024
Contributor
IceSentry
left a comment
IceSentry
left a comment
There was a problem hiding this comment.
Adding a skybox to the motion_blur example would be nice
Contributor
|
Uh, I meant that as a comment, not an approve 😅 |
IceSentry
reviewed
Jun 2, 2024
IceSentry
approved these changes
Jun 2, 2024
Contributor
IceSentry
left a comment
IceSentry
left a comment
There was a problem hiding this comment.
LGTM assuming comments are adressed
IceSentry
added
S-Waiting-on-Author
IceSentry
reviewed
Jun 2, 2024
Member
Author
I agree. I tried this out, but frankly it looks awful with the skyboxes we have available in tree. It would be nice if we had a simpler sky-and-clouds skybox and envmap. |
torsteingrindvik
approved these changes
Jun 2, 2024
aevyrie
added
S-Ready-For-Final-Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Solution
Testing
Screen.Recording.2024-06-01.at.1.59.19.AM.mp4