Skip to content

initial work towards ordering schedules within state transition groups#13724

Closed
lee-orr wants to merge 2 commits intobevyengine:mainfrom
lee-orr:attempt-fix-for-state-transition-ordering
Closed

initial work towards ordering schedules within state transition groups#13724
lee-orr wants to merge 2 commits intobevyengine:mainfrom
lee-orr:attempt-fix-for-state-transition-ordering

Conversation

@lee-orr
Copy link
Contributor

@lee-orr lee-orr commented Jun 6, 2024

Objective

Fixes #13711

Solution

Testing

  • Did you test these changes? If so, how?
  • Are there any parts that need more testing?
  • How can other people (reviewers) test your changes? Is there anything specific they need to know?
  • If relevant, what platforms did you test these changes on, and are there any important ones you can't test?

Changelog

This section is optional. If this was a trivial fix, or has no externally-visible impact, you can delete this section.

  • What changed as a result of this PR?
  • If applicable, organize changes under "Added", "Changed", or "Fixed" sub-headings
  • Stick to one or two sentences. If more detail is needed for a particular change, consider adding it to the "Solution" section
    • If you can't summarize the work, your change may be unreasonably large / unrelated. Consider splitting your PR to make it easier to review and merge!

Migration Guide

This section is optional. If there are no breaking changes, you can delete this section.

  • If this PR is a breaking change (relative to the last release of Bevy), describe how a user might need to migrate their code to support these changes
  • Simply adding new functionality is not a breaking change.
  • Fixing behavior that was definitely a bug, rather than a questionable design choice is not a breaking change.

@alice-i-cecile alice-i-cecile added C-Bug An unexpected or incorrect behavior A-ECS Entities, components, systems, and events labels Jun 7, 2024
@alice-i-cecile alice-i-cecile added this to the 0.14 milestone Jun 7, 2024
@alice-i-cecile alice-i-cecile added the S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged label Jun 9, 2024
@alice-i-cecile alice-i-cecile self-requested a review June 9, 2024 13:10
@alice-i-cecile
Copy link
Member

alice-i-cecile commented Jun 9, 2024

Good, I like this solution! Bother me when this is ready for review please. We'll ship this with 0.14.

@alice-i-cecile
Copy link
Member

Closing in favor of #13763.

I am happy with @mini's solution - it feels a bit clearer than mine, and they set up some initial tests & made the necessary doc changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ECS Entities, components, systems, and events C-Bug An unexpected or incorrect behavior S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ordered OnExit and OnEnter

2 participants