Update serialize flag for bevy_ecs#13740
Conversation
Because features are additive, you can actually get this by pulling a direct dependency on |
alice-i-cecile
added
C-Bug
|
You added a new example but didn't add metadata for it. Please update the root Cargo.toml file. |
alice-i-cecile
added
the
S-Needs-Review
|
CI seems very confused about your PR: I don't understand either the failures or the warning about missing examples. |
|
You added a new example but didn't add metadata for it. Please update the root Cargo.toml file. |
|
@alice-i-cecile should be good now :) |
alice-i-cecile
added
S-Ready-For-Final-Review
# Objective There were some issues with the `serialize` feature: - `bevy_app` had a `serialize` feature and a dependency on `serde` even there is no usage of serde at all inside `bevy_app` - the `bevy_app/serialize` feature enabled `bevy_ecs/serde`, which is strange - `bevy_internal/serialize` did not enable `bevy_app/serialize` so there was no way of serializing an Entity in bevy 0.14 ## Solution - Remove `serde` and `bevy_app/serialize` - Add a `serialize` flag on `bevy_ecs` that enables `serde` - ` bevy_internal/serialize` now enables `bevy_ecs/serialize`
|
Just tested this with leafwing-input-manager and rc.4. The bevy_ecs serde flag hack now causes an error. Removing it seems to fix the build error. |
4 participants
Objective
There were some issues with the
serializefeature:bevy_apphad aserializefeature and a dependency onserdeeven there is no usage of serde at all insidebevy_appbevy_app/serializefeature enabledbevy_ecs/serde, which is strangebevy_internal/serializedid not enablebevy_app/serializeso there was no way of serializing an Entity in bevy 0.14Solution
serdeandbevy_app/serializeserializeflag onbevy_ecsthat enablesserdebevy_internal/serializenow enablesbevy_ecs/serialize