Add from_color to StandardMaterial and ColorMaterial#13791
Merged
alice-i-cecile merged 2 commits intobevyengine:mainfrom Jun 10, 2024
Merged
Add from_color to StandardMaterial and ColorMaterial#13791alice-i-cecile merged 2 commits intobevyengine:mainfrom
from_color to StandardMaterial and ColorMaterial#13791alice-i-cecile merged 2 commits intobevyengine:mainfrom
Conversation
alice-i-cecile
approved these changes
Jun 10, 2024
alice-i-cecile
added
D-Trivial
Brezak
force-pushed
the
standard_material_from_color
branch
from
9fe7db4 to
d41c570
Compare
NthTensor
approved these changes
Jun 10, 2024
Contributor
NthTensor
left a comment
NthTensor
left a comment
There was a problem hiding this comment.
Much nicer than From in this case. Good addition.
NthTensor
added
S-Ready-For-Final-Review
mockersf
pushed a commit
that referenced
this pull request
Jun 11, 2024
# Objective Closes #13738 ## Solution Added `from_color` to materials that would support it. Didn't add `from_color` to `WireframeMaterial` as it doesn't seem we expect users to be constructing them themselves. ## Testing None --- ## Changelog ### Added - `from_color` to `StandardMaterial` so you can construct this material from any color type. - `from_color` to `ColorMaterial` so you can construct this material from any color type.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Closes #13738
Solution
Added
from_colorto materials that would support it. Didn't addfrom_colortoWireframeMaterialas it doesn't seem we expect users to be constructing them themselves.Testing
None
Changelog
Added
from_colortoStandardMaterialso you can construct this material from any color type.from_colortoColorMaterialso you can construct this material from any color type.