Revert "constrain WorldQuery::init_state argument to ComponentInitial…#13804
Merged
alice-i-cecile merged 1 commit intobevyengine:mainfrom Jun 11, 2024
Merged
Revert "constrain WorldQuery::init_state argument to ComponentInitial…#13804alice-i-cecile merged 1 commit intobevyengine:mainfrom
alice-i-cecile merged 1 commit intobevyengine:mainfrom
Conversation
…izer (bevyengine#13442)" This reverts commit 5cfb063.
alice-i-cecile
approved these changes
Jun 11, 2024
Member
alice-i-cecile
left a comment
alice-i-cecile
left a comment
There was a problem hiding this comment.
I agree with this as a next step.
alice-i-cecile
added
A-ECS
Contributor
|
This should reopen #13358 on merge. |
Victoronz
approved these changes
Jun 11, 2024
alice-i-cecile
added
S-Ready-For-Final-Review
mockersf
pushed a commit
that referenced
this pull request
Jun 11, 2024
#13804) …izer (#13442)" This reverts commit 5cfb063. - This PR broke bevy-trait-query, which needs to be able to write a resource in init_state. See #13798 for more details. - Note this doesn't fix everything as transmutes for bevy-trait-query will still be broken,. But the current usage in that crate is UB, so we need to find another solution.
BD103
added a commit
to BD103/bevy-website
that referenced
this pull request
Jun 19, 2024
This change was reverted because it broke `bevy-trait-query`. See bevyengine/bevy#13804 for more details.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…izer (#13442)"
This reverts commit 5cfb063.
bevy-trait-querybreakage after changes toWorldQueryAPI #13798 for more details.