Mark events as read during EventReader::par_read#13836
Merged
alice-i-cecile merged 8 commits intobevyengine:mainfrom Jun 25, 2024
Merged
Mark events as read during EventReader::par_read#13836alice-i-cecile merged 8 commits intobevyengine:mainfrom
EventReader::par_read#13836alice-i-cecile merged 8 commits intobevyengine:mainfrom
Conversation
This was referenced Jun 13, 2024
janhohenheim
added
C-Bug
Co-authored-by: Martín Maita <47983254+mnmaita@users.noreply.github.com>
BD103
reviewed
Jun 18, 2024
BD103
added
S-Ready-For-Final-Review
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Member
|
@BobG1983 I'd like to include this in 0.14 due to the severity of the bug, but CI is failing in a way that seems real. See https://github.com/bevyengine/bevy/actions/runs/9663589923/job/26656115871#step:5:208 for the error. |
Contributor
Author
|
So, I think this is a seperate bug. This should have failed previously, it's caused by the pariter iterator being included without multi_threading. Previously it did nothing (par_read made an iterator, but the iterators body was blank). This was fine until I added mut to the function signature, now its making clippy complain. To fix it I should remove ParIter entirely in non-muilti_threaded builds. |
Contributor
Author
|
Nearly done |
Contributor
Author
|
Done |
alice-i-cecile
changed the title
EventReader::par_read
cBournhonesque
pushed a commit
to cBournhonesque/bevy
that referenced
this pull request
Jun 25, 2024
# Objective - Fix issue bevyengine#13821 ## Solution - Rewrote the test to ensure that it actually tests the functionality correctly. Then made the par_read function correctly change the values of self.reader.last_event_count. ## Testing - Rewrote the test for par_read to run the system schedule twice, checking the output each time --------- Co-authored-by: Martín Maita <47983254+mnmaita@users.noreply.github.com>
mockersf
pushed a commit
that referenced
this pull request
Jun 25, 2024
Fix for par_read bugs retargetting 0.14. Remakes #13836.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Solution
Testing