Replaced implicit emissive weight with default.#13871
Merged
alice-i-cecile merged 1 commit intobevyengine:mainfrom Sep 9, 2024
Merged
Replaced implicit emissive weight with default.#13871alice-i-cecile merged 1 commit intobevyengine:mainfrom
alice-i-cecile merged 1 commit intobevyengine:mainfrom
Conversation
Since StandardMaterial::emissive_exposure_weight does not get packed into the gbuffer in the deferred case, unpacking uses an implicit default value for emissive's alpha channel. This resulted in divergent behavior between the forward and deferred renderers when using standard materials with default emissive_exposure_weight, this value defaulting to 0.0 in the forward case and 1.0 in the other. This patch changes the implicit value in the deferred case to 0.0 in order to match the behavior of the forward renderer. However, this still does not solve the case where emissive_exposure_weight is not 0.0.
alice-i-cecile
added
C-Bug
alice-i-cecile
added
the
S-Needs-Review
pcwalton
approved these changes
Jul 14, 2024
Contributor
pcwalton
left a comment
pcwalton
left a comment
There was a problem hiding this comment.
Seems fine, not ideal but an improvement on what we have.
alice-i-cecile
added
the
M-Migration-Guide
Contributor
|
It looks like your PR is a breaking change, but you didn't provide a migration guide. Could you add some context on what users should update when this change get released in a new version of Bevy? |
janhohenheim
approved these changes
Sep 5, 2024
Member
janhohenheim
left a comment
janhohenheim
left a comment
There was a problem hiding this comment.
Agreed, it's at least better than the status quo
janhohenheim
added
S-Ready-For-Final-Review
Contributor
|
I don't know that we should merge this until #14599 is finished. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since
StandardMaterial::emissive_exposure_weightdoes not get packed into the gbuffer in the deferred case, unpacking uses an implicit default value for emissive's alpha channel.This resulted in divergent behavior between the forward and deferred renderers when using standard materials with default emissive_exposure_weight, this value defaulting to
0.0in the forward case and1.0in the other.This patch changes the implicit value in the deferred case to
0.0in order to match the behavior of the forward renderer. However, this still does not solve the case whereemissive_exposure_weightis not0.0.