Skip to content

Allow observer systems to have outputs#14159

Merged
alice-i-cecile merged 2 commits intobevyengine:mainfrom
cBournhonesque:cb/pipe-observer-systems
Jul 15, 2024
Merged

Allow observer systems to have outputs#14159
alice-i-cecile merged 2 commits intobevyengine:mainfrom
cBournhonesque:cb/pipe-observer-systems

Conversation

@cBournhonesque
Copy link
Contributor

Objective

Fixes #14157

Solution

  • Update the ObserverSystem traits to accept an Out parameter

Testing

  • Added a test where an observer system has a non-empty output which is piped into another system

@cBournhonesque cBournhonesque added the A-ECS Entities, components, systems, and events label Jul 5, 2024
@cBournhonesque cBournhonesque modified the milestones: 0.14.1, 0.15 Jul 5, 2024
Copy link
Member

@janhohenheim janhohenheim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was quick, thanks!

@janhohenheim janhohenheim added the D-Straightforward Simple bug fixes and API improvements, docs, test and examples label Jul 5, 2024
@janhohenheim janhohenheim modified the milestones: 0.15, 0.14.1 Jul 5, 2024
@janhohenheim janhohenheim added C-Bug An unexpected or incorrect behavior P-Compile-Failure A failure to compile Bevy apps S-Needs-Review Needs reviewer attention (from anyone!) to move forward and removed P-Compile-Failure A failure to compile Bevy apps labels Jul 5, 2024
@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jul 9, 2024
@alice-i-cecile alice-i-cecile enabled auto-merge July 15, 2024 14:49
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jul 15, 2024
Merged via the queue into bevyengine:main with commit da997dd Jul 15, 2024
mockersf pushed a commit that referenced this pull request Aug 2, 2024
Fixes #14157

- Update the ObserverSystem traits to accept an `Out` parameter

- Added a test where an observer system has a non-empty output which is
piped into another system

Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ECS Entities, components, systems, and events C-Bug An unexpected or incorrect behavior D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Piping values does not work on observers

3 participants