Fix overflow in RenderLayers::iter_layers#14264
Merged
alice-i-cecile merged 1 commit intobevyengine:mainfrom Jul 15, 2024
Merged
Fix overflow in RenderLayers::iter_layers#14264alice-i-cecile merged 1 commit intobevyengine:mainfrom
RenderLayers::iter_layers#14264alice-i-cecile merged 1 commit intobevyengine:mainfrom
Conversation
SpecificProtagonist
approved these changes
Jul 10, 2024
alice-i-cecile
added
C-Bug
alice-i-cecile
approved these changes
Jul 14, 2024
alice-i-cecile
added
S-Ready-For-Final-Review
mockersf
pushed a commit
that referenced
this pull request
Aug 2, 2024
# Objective - Fixes overflow when calling `RenderLayers::iter_layers` on layers of the form `k * 64 - 1` - Causes a panic in debug mode, and an infinite iterator in release mode ## Solution - Use `u64::checked_shr` instead of `>>=` ## Testing - Added a test case for this: `render_layer_iter_no_overflow`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
RenderLayers::iter_layerson layers of the formk * 64 - 1Solution
u64::checked_shrinstead of>>=Testing
render_layer_iter_no_overflow