Better documentation for explicit dependencies#1428
Merged
cart merged 7 commits intobevyengine:masterfrom Feb 16, 2021
alice-i-cecile:ambiguity-docs
Merged
Better documentation for explicit dependencies#1428cart merged 7 commits intobevyengine:masterfrom alice-i-cecile:ambiguity-docs
cart merged 7 commits intobevyengine:masterfrom
alice-i-cecile:ambiguity-docs
Conversation
Ratysz
suggested changes
Feb 11, 2021
Member
Author
|
Thanks @Ratysz; all your comments are resolved now :) |
Ratysz
approved these changes
Feb 11, 2021
Member
|
/rebase |
Co-authored-by: Alexander Sepity <ratysz@gmail.com>
Co-authored-by: Alexander Sepity <ratysz@gmail.com>
Co-authored-by: Alexander Sepity <ratysz@gmail.com>
Member
|
Looks good to me! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR works to improve the documentation and examples around explicit dependencies and the ambiguity checker that were added in #1144.
It also removes the advice of "just make more stages!" for when you want to make sure your systems run in a particular order ;)