Fix error/typo in SMAA shader#14338
Merged
mockersf merged 2 commits intobevyengine:mainfrom Jul 15, 2024
Merged
Conversation
As in the original SMAA implementation: https://github.com/iryoku/smaa/blob/master/SMAA.hlsl#L960
`.z` -> `.y`
rparrett
approved these changes
Jul 15, 2024
Contributor
rparrett
left a comment
rparrett
left a comment
There was a problem hiding this comment.
Makes sense to me. This sort of nonsense is necessary due to gpuweb/gpuweb#737.
alice-i-cecile
approved these changes
Jul 15, 2024
alice-i-cecile
added
C-Bug
Contributor
|
Checked the output of |
mockersf
approved these changes
Jul 15, 2024
mockersf
pushed a commit
that referenced
this pull request
Aug 2, 2024
# Objective - Actually use the value assigned to `d_xz`, like in [the original SMAA implementation](https://github.com/iryoku/smaa/blob/master/SMAA.hlsl#L960). This not already being the case was likely a mistake when converting from HLSL to WGSL ## Solution - Use `d_xz.x` and `d_xz.y` instead of `d.x` and `d.z` ## Testing - Quickly tested on Windows 11, `x86_64-pc-windows-gnu` `1.79.0` with the latest NVIDIA drivers. App runs with SMAA enabled and everything seems to work as intended - I didn't observe any major visual difference between this and the previous version, though this should be more correct as it matches the original SMAA implementation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
d_xz, like in the original SMAA implementation. This not already being the case was likely a mistake when converting from HLSL to WGSLSolution
d_xz.xandd_xz.yinstead ofd.xandd.zTesting
x86_64-pc-windows-gnu1.79.0with the latest NVIDIA drivers. App runs with SMAA enabled and everything seems to work as intended