Skip to content

Fix missing paths in ECS SystemParam derive macro#1434

Merged
cart merged 1 commit intobevyengine:masterfrom
woubuc:fix/ecs-macro-systemparam
Feb 11, 2021
Merged

Fix missing paths in ECS SystemParam derive macro#1434
cart merged 1 commit intobevyengine:masterfrom
woubuc:fix/ecs-macro-systemparam

Conversation

@woubuc
Copy link
Contributor

@woubuc woubuc commented Feb 11, 2021

The SystemParam derive macro had some missing path scopes, which lead to SystemParam not correctly getting resolved in some situations.

@cart
Copy link
Member

cart commented Feb 11, 2021

Looks good to me. Nice catch!

@cart
Copy link
Member

cart commented Feb 11, 2021

/rebase

@cart cart force-pushed the fix/ecs-macro-systemparam branch from a371dc8 to cff828d Compare February 11, 2021 22:09
@cart cart merged commit b39df9a into bevyengine:master Feb 11, 2021
@TheRawMeatball TheRawMeatball mentioned this pull request Feb 16, 2021
bors bot pushed a commit that referenced this pull request Aug 10, 2021
This is an updated version of #1434 PR. I've encountered this macro problem while trying to use @woubuc's bevy-event-set crate.

Co-authored-by: Piotr Balcer <piotr@balcer.eu>
bors bot pushed a commit that referenced this pull request Aug 11, 2021
This is an updated version of #1434 PR. I've encountered this macro problem while trying to use @woubuc's bevy-event-set crate.

Co-authored-by: Piotr Balcer <piotr@balcer.eu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants