Fix single keyframe animations.#14344
Merged
alice-i-cecile merged 1 commit intobevyengine:mainfrom Jul 22, 2024
Merged
Conversation
alice-i-cecile
added
C-Bug
alice-i-cecile
added
the
S-Needs-Review
MrGVSV
approved these changes
Jul 16, 2024
Member
MrGVSV
left a comment
MrGVSV
left a comment
There was a problem hiding this comment.
Don't know much about animation, but the change does look more correct to me.
IQuick143
approved these changes
Jul 16, 2024
Contributor
IQuick143
left a comment
IQuick143
left a comment
There was a problem hiding this comment.
Also not an animation guy, but the changes match up to the PR desc.
Would be nice if there was an unit test for this.
mweatherley
approved these changes
Jul 17, 2024
Contributor
mweatherley
left a comment
mweatherley
left a comment
There was a problem hiding this comment.
Nice catch! I'm surprised I hadn't noticed this after staring at this code for so long.
mweatherley
added
S-Ready-For-Final-Review
mockersf
pushed a commit
that referenced
this pull request
Aug 2, 2024
# Objective For clips with more than one curve, only the first was being applied if there is only one keyframe in it. ## Solution Continue!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
For clips with more than one curve, only the first was being applied if there is only one keyframe in it.
Solution
Continue!