[Merged by Bors] - Add docs & example for SystemParam#1435
Closed
woubuc wants to merge 5 commits intobevyengine:mainfrom
Closed
[Merged by Bors] - Add docs & example for SystemParam#1435woubuc wants to merge 5 commits intobevyengine:mainfrom
woubuc wants to merge 5 commits intobevyengine:mainfrom
Conversation
MinerSebas
reviewed
Feb 14, 2021
# Conflicts: # crates/bevy_ecs/macros/src/lib.rs
Contributor
Author
|
I've fixed the conflicts from #1426 and replaced my local fix with the better fix from that commit. Should be good to go now. |
Member
|
Looks good to me. Thanks! |
Member
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Mar 3, 2021
It took me a little while to figure out how to use the `SystemParam` derive macro to easily create my own params. So I figured I'd add some docs and an example with what I learned. - Fixed a bug in the `SystemParam` derive macro where it didn't detect the correct crate name when used in an example (no longer relevant, replaced by #1426 - see further) - Added some doc comments and a short example code block in the docs for the `SystemParam` trait - Added a more complete example with explanatory comments in examples
Contributor
|
Pull request successfully merged into main. Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It took me a little while to figure out how to use the
SystemParamderive macro to easily create my own params. So I figured I'd add some docs and an example with what I learned.SystemParamderive macro where it didn't detect the correct crate name when used in an example (no longer relevant, replaced by [Merged by Bors] - fix bevy_ecs macro path handling #1426 - see further)SystemParamtrait