Disabled usage of the POLYGON_MODE_LINE gpu feature in the examples#14402
Merged
alice-i-cecile merged 6 commits intobevyengine:mainfrom Jul 29, 2024
Merged
Disabled usage of the POLYGON_MODE_LINE gpu feature in the examples#14402alice-i-cecile merged 6 commits intobevyengine:mainfrom
alice-i-cecile merged 6 commits intobevyengine:mainfrom
Conversation
janhohenheim
added
C-Bug
Member
|
Could you also update the 2d_shapes example? |
mockersf
reviewed
Jul 20, 2024
Contributor
Author
Updated |
mockersf
approved these changes
Jul 23, 2024
Member
mockersf
left a comment
mockersf
left a comment
There was a problem hiding this comment.
Could you add a comment to the 2d_shapes and 3d_shapes examples explaining that wireframe doesn't work in Wasm?
Signed-off-by: Sarthak Singh <sarthak.singh99@gmail.com>
SarthakSingh31
force-pushed
the
sar/no-poly-line
branch
from
8cb179f to
126d2c1
Compare
mockersf
approved these changes
Jul 23, 2024
Member
|
thanks! |
BD103
approved these changes
Jul 29, 2024
Member
BD103
left a comment
BD103
left a comment
There was a problem hiding this comment.
Looks good! I have one non-blocking request to add a comment, but no worries if you don't get around to it :)
alice-i-cecile
added
S-Ready-For-Final-Review
Co-authored-by: BD103 <59022059+BD103@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14353
Fixes #14371