Fix bevy_winit not building with serialize feature#14469
Merged
mockersf merged 1 commit intobevyengine:mainfrom Jul 26, 2024
Merged
Fix bevy_winit not building with serialize feature#14469mockersf merged 1 commit intobevyengine:mainfrom
bevy_winit not building with serialize feature#14469mockersf merged 1 commit intobevyengine:mainfrom
Conversation
BD103
added
C-Bug
janhohenheim
approved these changes
Jul 26, 2024
mockersf
approved these changes
Jul 26, 2024
janhohenheim
added
S-Ready-For-Final-Review
mockersf
pushed a commit
that referenced
this pull request
Aug 2, 2024
# Objective - `bevy_winit` fails to build with just the `serialize` feature. - Caught by [`flag-frenzy`](https://github.com/TheBevyFlock/flag-frenzy) in [this run](https://github.com/TheBevyFlock/flag-frenzy/actions/runs/10087486444/job/27891723948), using the new, nuanced configuration system! ## Solution - It was failing because `bevy_winit` did not pass the `serialize` flag to two of its dependencies: `bevy_input` and `bevy_window`. - To fix this, add these crates to the feature flag. ## Testing ```bash # On Linux, you must also specify a backend: `x11` or `wayland`. # You can do this with `-F serialize,x11`, etc. cargo check -p bevy_winit --no-default-features -F serialize ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
bevy_winitfails to build with just theserializefeature.flag-frenzyin this run, using the new, nuanced configuration system!Solution
bevy_winitdid not pass theserializeflag to two of its dependencies:bevy_inputandbevy_window.Testing