Fix bevy_gltf PBR features not enabling corresponding bevy_pbr flags#14486
Merged
alice-i-cecile merged 2 commits intobevyengine:mainfrom Jul 26, 2024
Merged
Fix bevy_gltf PBR features not enabling corresponding bevy_pbr flags#14486alice-i-cecile merged 2 commits intobevyengine:mainfrom
bevy_gltf PBR features not enabling corresponding bevy_pbr flags#14486alice-i-cecile merged 2 commits intobevyengine:mainfrom
Conversation
BD103
added
C-Bug
JMS55
approved these changes
Jul 26, 2024
Contributor
|
@alice-i-cecile this should be 0.14.1 no? |
Member
Author
I don't think it would hurt, but it's also unlikely that someone would run into this issue and require the fix. I'm happy without whatever Alice decides :) |
janhohenheim
approved these changes
Jul 26, 2024
janhohenheim
added
S-Ready-For-Final-Review
mockersf
pushed a commit
that referenced
this pull request
Aug 2, 2024
…ags (#14486) # Objective - `bevy_gltf` does not build with only the `pbr_multi_layer_material_textures` or `pbr_anisotropy_texture` features. - Caught by [`flag-frenzy`](https://github.com/TheBevyFlock/flag-frenzy) in [this run](https://github.com/TheBevyFlock/flag-frenzy/actions/runs/10087486444/job/27891723948). ## Solution - This error was due to the feature not enabling the corresponding feature in `bevy_pbr`. Adding these flags as a dependency fixes this error. ## Testing The following commands fail on `main`, but pass with this PR: ```bash cargo check -p bevy_gltf --no-default-features -F pbr_multi_layer_material_textures cargo check -p bevy_gltf --no-default-features -F pbr_anisotropy_texture ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
bevy_gltfdoes not build with only thepbr_multi_layer_material_texturesorpbr_anisotropy_texturefeatures.flag-frenzyin this run.Solution
bevy_pbr. Adding these flags as a dependency fixes this error.Testing
The following commands fail on
main, but pass with this PR: