[Merged by Bors] - Add getter for RenderGraph Node uuid#1499
Closed
mtsr wants to merge 2 commits intobevyengine:mainfrom
Closed
[Merged by Bors] - Add getter for RenderGraph Node uuid#1499mtsr wants to merge 2 commits intobevyengine:mainfrom
mtsr wants to merge 2 commits intobevyengine:mainfrom
Conversation
Ratysz
added
A-Rendering
Contributor
|
Don't forget about Unrelated note, wasn't there a fix to reduce the noise in CI?.. It's pretty hard to dig stuff out. |
Contributor
Author
|
Thanks. I've been toggling formatting on and off in my editor, because I ran into some projects without |
Ratysz
approved these changes
Feb 22, 2021
Member
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Feb 22, 2021
`RenderGraph` errors only give the `Uuid` of the node. So for my graphviz dot based visualization of the `RenderGraph` I really wanted to show it to the user. I think it makes sense to have it accessible for at least debugging purposes.
Contributor
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
Member
bors bot
pushed a commit
that referenced
this pull request
Mar 7, 2021
Silence those [annoying rustfmt config warnings](https://github.com/bevyengine/bevy/pull/1499/checks?check_run_id=1950282111#step:5:66) that happen because we have unstable rustfmt options in `rustfmt.toml`, but we run it in stable on CI. Thanks to @Ratysz for [calling it out](#1499 (comment)). 😄 The final approach we settled on was to comment out the unstable options in `rustfmt.toml`. Those who are using `nightly` may uncomment the unstable options locally if they wish. Once the options stabilize, we can uncomment them again. We also decided that instead of fixing the alias, we would remove the alias entirely so that we do not introduce a custom `.cargo/config.toml` that would conflict with users' custom version of the same file. This means that instead of using a `cargo ci` alias you should use `cargo run -p ci` or `cargo run --package ci` instead. <details><summary>Original Approach (abandoned)</summary> <p> _We decided **not** to go this way..._ In my quest to find a portable way to filter out the warnings I switched the library used to execute commands from `xshell` to `duct` (as advised by the `xshell` project itself when you want to do less simple things). This still uses the "xtask" pattern of using a cargo command alias and a rust project for what would have usually been done with a bash script (on posix), just a different helper library is being used internally. NOTE 1: Also, thanks to some sleuthing by @DJMcNab we were able to fix the broken cargo alias. The issue turned out to be that `.cargo/config.toml` was being ignored because of `.gitignore`. NOTE 2: This is a [known breaking change](#1309 (comment)) for anyone working on bevy who has their own local `.cargo/config.toml`. </p> </details>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RenderGrapherrors only give theUuidof the node. So for my graphviz dot based visualization of theRenderGraphI really wanted to show it to the user. I think it makes sense to have it accessible for at least debugging purposes.