Revert accidentally added asset docs#15054
Merged
alice-i-cecile merged 1 commit intobevyengine:mainfrom Sep 5, 2024
Merged
Conversation
This reverts commit ba1f13f. Revert "Add note on `AssetServer::load` not being wasteful" This reverts commit 480c2bc. Revert "Basic practical overview" This reverts commit a4b51d7. Revert "Clarify relationships between saving, loading, reading and writing" This reverts commit 22aa9ab. Revert "Add advice on handles and reference counting" This reverts commit f016aea. Revert "Basic docs for `Asset` and `VisitAssetDependencies`" This reverts commit 77c5efc. Revert "Initial overview" This reverts commit 1a9e55f.
alice-i-cecile
added
P-High
Jondolf
approved these changes
Sep 5, 2024
alice-i-cecile
added
S-Ready-For-Final-Review
BD103
approved these changes
Sep 5, 2024
alice-i-cecile
added a commit
to alice-i-cecile/bevy
that referenced
this pull request
Sep 5, 2024
This reverts commit 5589f0d.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 17, 2024
# Objective Bevy's asset system is powerful and generally well-designed but very opaque. Beginners struggle to discover how to do simple tasks and grok the fundamental data models, while more advanced users trip over the assorted traits and their relation to each other. Reverts #15054 ;) ## Solution This PR adds module documentation to `bevy_assets`, tweaking the associated documentation on the items as needed to provide further details and bread crumbs. If you have ideas for other important, hard-to-discover patterns or functionality in this crate, please let me know. That said, I've left out a section on asset preprocessing which *should* eventually go here. That is substantially more uncertain, and requires both more time to investigate and more expertise to review. --------- Co-authored-by: Carter Anderson <mcanders1@gmail.com> Co-authored-by: TrialDragon <31419708+TrialDragon@users.noreply.github.com> Co-authored-by: NotAFile <notafile@gmail.com> Co-authored-by: Zachary Harrold <zac@harrold.com.au> Co-authored-by: JMS55 <47158642+JMS55@users.noreply.github.com> Co-authored-by: Jan Hohenheim <jan@hohenheim.ch>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our branch protection rules were misconfigured, allowing me to push directly to
origin/main😱 This is now resolved:This PR reverts those accidental changes, which will get their own PR momentarily...