Skip to content

[Merged by Bors] - Fix typo in Xtask CI#1526

Closed
lambdagolem wants to merge 1 commit intobevyengine:mainfrom
lambdagolem:main
Closed

[Merged by Bors] - Fix typo in Xtask CI#1526
lambdagolem wants to merge 1 commit intobevyengine:mainfrom
lambdagolem:main

Conversation

@lambdagolem
Copy link
Contributor

I think there was a typo here. If this is not a typo and I misunderstood the comment please just ignore this PR.

@bjorn3 bjorn3 added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Feb 26, 2021
@bjorn3
Copy link
Contributor

bjorn3 commented Feb 26, 2021

Thanks for the PR. Seems to be a typo to me too.

@mockersf
Copy link
Member

👋 it is an error indeed!

It should be fixed as part of #1508 , but this may go faster if discussion is still ongoing there

@Ratysz Ratysz added the A-Build-System Related to build systems or continuous integration label Feb 26, 2021
Copy link
Member

@CleanCut CleanCut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, also fixed in #1508. This PR can be merged or closed. Either way works.

@cart
Copy link
Member

cart commented Mar 3, 2021

bors r+

bors bot pushed a commit that referenced this pull request Mar 3, 2021
 I think there was a typo here. If this is not a typo and I misunderstood the comment please just ignore this PR.
@bors
Copy link
Contributor

bors bot commented Mar 3, 2021

@bors bors bot changed the title Fix typo in Xtask CI [Merged by Bors] - Fix typo in Xtask CI Mar 3, 2021
@bors bors bot closed this Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Build-System Related to build systems or continuous integration S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants