Replace Handle<M: UiMaterial> component with UiMaterialHandle wrapper #15740
Merged
alice-i-cecile merged 3 commits intobevyengine:mainfrom Oct 8, 2024
Merged
Replace Handle<M: UiMaterial> component with UiMaterialHandle wrapper #15740alice-i-cecile merged 3 commits intobevyengine:mainfrom
Handle<M: UiMaterial> component with UiMaterialHandle wrapper #15740alice-i-cecile merged 3 commits intobevyengine:mainfrom
Conversation
…andles-ui-material
tim-blackbird
added
A-UI
IceSentry
approved these changes
Oct 8, 2024
Contributor
IceSentry
left a comment
IceSentry
left a comment
There was a problem hiding this comment.
Naming is hard 🙃 . I don't want to rename the Material2d/3d stuff, but yeah this isn't ideal.
Contributor
Author
|
Oops, this component should have some docs |
alice-i-cecile
approved these changes
Oct 8, 2024
alice-i-cecile
added
S-Ready-For-Final-Review
Member
|
Yeah, I'm fine with merging this as is. Consistency would be nice but I really don't see a good path for that... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Handle<T: UiMaterial>as a component #15720Solution
Wrap the handle in a new wrapper component:
UiMaterialHandleIt's not possible to match the naming convention of
MeshMaterial3d/2dhere with the trait already being calledUiMaterialShould we consider renaming to
Material3d/2dHandleandMesh3d/2dtoMesh3d/2dHandle?Testing
Tested the
ui_materialexampleMigration Guide
Let's defer the migration guide to the required component port. I just want to yeet the
Componentimpl onHandlein the meantime :)