Rename TextBlock to TextLayout

[UkoeHB]

Objective

• Improve clarity when spawning a text block. See this discussion.

Solution

• Rename TextBlock to TextLayout.

[alice-i-cecile]

I prefer this naming. I think this is much clearer: it's more adjective-y, rather than being a distinct noun.

[cart]

From my perspective this should still be a "driving concept" with a noun. TextLayout feels like it is "just" describing the text layout configuration. But imo we can (and should) make this the driving concept for "thing that receives text spans and renders them". TextBlock feels like the better name in that context.

[cart]

But if we commit to this just being "text layout configuration" from a user perspective, this rename is fine

[UkoeHB]

Right now the requires are

• Text -> {TextStyle, TextBlock -> {ComputedTextBlock, TextLayoutInfo}}.

What if we rearrange like this

• Text -> {TextStyle, ComputedTextBlock -> {TextLayout, TextLayoutInfo}} or
• Text -> {TextStyle, TextLayout, ComputedTextBlock -> {TextLayout, TextLayoutInfo}}?

It feels quite wrong to me to make a TextBlock component to set text layout configs, just because the name TextBlock fits into some unrelated semantic structure.

[cart]

Hmm that would have conceptual / ergonomic implications when trying to use the "TextBlock" concept (in your proposal ComputedTextBlock) directly:

commands.spawn((Node, ComputedTextBlock, TextLayout::new_with_justify(JustifyText::Center))

Vs

commands.spawn((Node, TextBlock::new_with_justify(JustifyText::Center))

That being said, with the current impl this standalone usage is not currently possible, and I'm not really sure we even need it.

In the short term I'm cool with TextLayout, provided it is used "just" for config. I agree that the introduction of a "non layout" concept does muddle things when that new concept isn't currently actually used anywhere outside of layout. If we later decide that TextBlock is a useful user facing concept, we can re-open the discussion.