Fix sprite and picking examples#15803
Merged
alice-i-cecile merged 2 commits intobevyengine:mainfrom Oct 10, 2024
Merged
Conversation
Jondolf
added
D-Trivial
alice-i-cecile
approved these changes
Oct 9, 2024
alice-i-cecile
added
S-Ready-For-Final-Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Looks like #15489 broke some examples :) And there are some other issues as well.
Gabe's brother Gabe is tiny in the
sprite_animationexample:Gabe is not running in the
sprite_pickingexample, and (unrelated) is also very blurry: (note that the screenshot is a bit zoomed in)Unrelated to sprites, the text in the
simple_pickingexample is way too dark when hovered:Solution
Both Gabes are now the correct size:
Gabe is crisp and running:
The text has better contrast: