Skip to content

Fix panic in gamepad_viewer example when gamepad is connected#15854

Merged
alice-i-cecile merged 1 commit intobevyengine:mainfrom
rparrett:fix-gamepad-viewer
Oct 11, 2024
Merged

Fix panic in gamepad_viewer example when gamepad is connected#15854
alice-i-cecile merged 1 commit intobevyengine:mainfrom
rparrett:fix-gamepad-viewer

Conversation

@rparrett
Copy link
Contributor

@rparrett rparrett commented Oct 11, 2024

Objective

Fixes #15832

Solution

It seems that this was just a transliteration mistake during #15591.

Update the correct text span index.

Testing

I tested on macos with:

cargo run --example gamepad_viewer

  • without gamepad connected
  • with gamepad connected
  • disconnecting and reconnecting gamepad while running

@rparrett rparrett requested a review from NiseVoid October 11, 2024 16:03
@alice-i-cecile alice-i-cecile added this to the 0.15 milestone Oct 11, 2024
@alice-i-cecile alice-i-cecile added C-Examples An addition or correction to our examples A-Input Player input via keyboard, mouse, gamepad, and more labels Oct 11, 2024
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Oct 11, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Oct 11, 2024
Merged via the queue into bevyengine:main with commit cdd71af Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Input Player input via keyboard, mouse, gamepad, and more C-Examples An addition or correction to our examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

gamepad_viewer example broken when a controller is connected

2 participants